Create pocketid.subdomain.conf.sample#790
Open
id4vip wants to merge 2 commits intolinuxserver:masterfrom
Open
Conversation
drizuid
reviewed
Jan 6, 2026
|
|
||
| server { | ||
| listen 443 ssl; | ||
| listen 443 quic; |
drizuid
reviewed
Jan 6, 2026
| listen 443 ssl; | ||
| listen 443 quic; | ||
| listen [::]:443 ssl; | ||
| listen [::]:443 quic; |
drizuid
reviewed
Jan 6, 2026
| # enable for Tinyauth (requires tinyauth-location.conf in the location block) | ||
| #include /config/nginx/tinyauth-server.conf; | ||
|
|
||
| if ($lan-ip = yes) { set $geo-whitelist yes; } |
Member
There was a problem hiding this comment.
you dont know that users want geoblocking or have the mod to support it
drizuid
reviewed
Jan 6, 2026
| #include /config/nginx/tinyauth-server.conf; | ||
|
|
||
| if ($lan-ip = yes) { set $geo-whitelist yes; } | ||
| if ($geo-whitelist = no) { return 404; } |
Member
There was a problem hiding this comment.
you dont know that users want geoblocking or have the mod to support it
drizuid
requested changes
Jan 6, 2026
Member
drizuid
left a comment
drizuid
left a comment
There was a problem hiding this comment.
please review how we handle proxy confs and address the numerous issues here.
do
| set $upstream_proto http; | ||
| proxy_pass $upstream_proto://$upstream_app:$upstream_port; | ||
|
|
||
| ## Version 2023/02/09 - Changelog: https://github.com/linuxserver/docker-swag/commits/master/root/defaults/nginx/proxy.conf.sample |
Member
There was a problem hiding this comment.
im not sure what you're doing here, but this doesn't belong in this file and it's highly unlikely we would make overarching changes to proxy.conf which affects everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Benefits of this PR and context
How Has This Been Tested?
Source / References